Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shebang): add support for env's split-string option #195

Merged

Conversation

dudeofawesome
Copy link

This is useful for passing arguments to node

This is useful for passing arguments to node
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add requested a review from scagood March 4, 2024 05:02
lib/rules/shebang.js Outdated Show resolved Hide resolved
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the extensiveness of the tests 😁

I have one blocker about the new regex, but once that is resolved I think we're good to go!

🚀

lib/rules/shebang.js Outdated Show resolved Hide resolved
@aladdin-add aladdin-add requested a review from scagood March 5, 2024 09:20
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🚀

@aladdin-add aladdin-add merged commit b383b49 into eslint-community:master Mar 5, 2024
17 checks passed
aladdin-add pushed a commit that referenced this pull request Mar 6, 2024
* feat(shebang): add support for env's split-string option

This is useful for passing arguments to node

* feat(shebang): support all `env` options

* feat(shebang): improve regex performance
aladdin-add pushed a commit that referenced this pull request Mar 6, 2024
* feat(shebang): add support for env's split-string option

This is useful for passing arguments to node

* feat(shebang): support all `env` options

* feat(shebang): improve regex performance
aladdin-add pushed a commit that referenced this pull request Mar 6, 2024
* feat(shebang): add support for env's split-string option

This is useful for passing arguments to node

* feat(shebang): support all `env` options

* feat(shebang): improve regex performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants