Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ES Syntax #189

Merged
merged 14 commits into from Mar 4, 2024
Merged

Conversation

scagood
Copy link

@scagood scagood commented Feb 23, 2024

This extracts the es-syntax data into a separate json file and updates all of it to be up-to-date!

tests/lib/rules/no-unsupported-features/es-syntax.js Outdated Show resolved Hide resolved
},
],
},
// TODO: Additional es-syntax
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented out no-property-shorthands-getset, and no-bigint-property-names. as I want to cover them in a less custom way.

I am open to ideas/suggestions

@scagood scagood marked this pull request as ready for review February 24, 2024 16:43
@scagood

This comment was marked as outdated.

@aladdin-add
Copy link

shouldn't be 'generators' is not supported until Node.js >=4.0.0. The configured version range is '3.9.9'.?

ruleId = ruleId.replace(/^no-/, '')

lib/rules/no-unsupported-features/es-syntax.js Outdated Show resolved Hide resolved
lib/rules/no-unsupported-features/es-syntax.js Outdated Show resolved Hide resolved
tests/lib/rules/no-unsupported-features/es-syntax.js Outdated Show resolved Hide resolved
lib/rules/no-unsupported-features/es-syntax.js Outdated Show resolved Hide resolved
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!

@aladdin-add aladdin-add merged commit 4778ae8 into eslint-community:master Mar 4, 2024
17 checks passed
@scagood scagood deleted the es-syntax branch April 10, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants