Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript (jsdoc) checking and definition generation #169

Merged
merged 21 commits into from Apr 7, 2024

Conversation

scagood
Copy link

@scagood scagood commented Jan 13, 2024

This is aiming to resolve #142

@aladdin-add aladdin-add self-assigned this Jan 16, 2024
@aladdin-add aladdin-add self-requested a review January 16, 2024 06:17
@aladdin-add
Copy link

How's the progress on this one?

eslint v9 is feature frozen, and this is the last one in v17.

@scagood

This comment was marked as outdated.

@scagood

This comment was marked as outdated.

@scagood scagood changed the title chore: add some low hanging fruit types feat: typescript (jsdoc) checking and definition generation Mar 21, 2024
@aladdin-add
Copy link

No hurry, please take your time. I just want to make sure we did not lose track of it. 😄

@scagood scagood marked this pull request as ready for review March 25, 2024 14:25
tsconfig.json Outdated Show resolved Hide resolved
@scagood

This comment was marked as outdated.

package.json Show resolved Hide resolved
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some late evening comments, didn't have time to look through all code unfortunately but overall I really really like it and it really rhymes with what I'm trying to do in eslint-community/eslint-utils#204 (and somewhat over the top in eslint/eslint-visitor-keys#66)

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
lib/util/visit-require.js Outdated Show resolved Hide resolved
lib/util/visit-require.js Outdated Show resolved Hide resolved
lib/util/check-prefer-global.js Outdated Show resolved Hide resolved
lib/unsupported-features/types.js Outdated Show resolved Hide resolved
lib/rules/no-unsupported-features/node-builtins.js Outdated Show resolved Hide resolved
lib/rules/no-deprecated-api.js Outdated Show resolved Hide resolved
lib/eslint-utils.d.ts Show resolved Hide resolved
],
"peerDependencies": {
"eslint": ">=8.23.0"
},
"dependencies": {
"@eslint-community/eslint-utils": "^4.4.0",
"@types/eslint": "^8.56.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove it here - it's already listed in devDependencies?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatly we can't until #213 is done as the types require the dependency :)

@aladdin-add aladdin-add merged commit 6d8ed14 into eslint-community:master Apr 7, 2024
17 checks passed
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and then file PR:s for any follow up improvements.

Would be great to get into next release.

@aladdin-add
Copy link

I'm merging it and going to push a pre-release.

@scagood scagood deleted the types branch April 7, 2024 11:57
@@ -133,11 +133,11 @@
},
"no-date-prototype-getyear-setyear": {
"supported": ">=0.10.0",
"deprecated": true
"supported": ">=0.10.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate line with line 135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Basic TypeScript types
4 participants