Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: false positives in 5.4.0 for functions that aren't ESLint rules #451

Merged
merged 5 commits into from
Mar 19, 2024
Merged

fix: false positives in 5.4.0 for functions that aren't ESLint rules #451

merged 5 commits into from
Mar 19, 2024

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Mar 18, 2024 •
edited

fixes #450

To make the ci happy:

  • updated eslint-remote-tester config
  • upgraded eslint-doc-generator

bradzacher
bradzacher approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yFYGqgv.jpeg

@aladdin-add aladdin-add merged commit f3ec88e into main Mar 19, 2024
12 checks passed
@aladdin-add aladdin-add deleted the issue450 branch March 19, 2024 05:16
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Merged
@bmish
Copy link
Member

bmish commented Mar 19, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@bmish bmish Awaiting requested review from bmish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New false positives in 5.4.0 for functions that aren't ESLint rules
3 participants
@aladdin-add @bmish @bradzacher