Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove consistent-output from recommended in future major version? #284

Closed
bmish opened this issue Aug 10, 2022 · 0 comments · Fixed by #462 or #460
Closed

Remove consistent-output from recommended in future major version? #284

bmish opened this issue Aug 10, 2022 · 0 comments · Fixed by #462 or #460
Labels
BREAKING CHANGE This change will require a major version bump

Comments

@bmish
Copy link
Member

bmish commented Aug 10, 2022

We had some previous discussion about this in #258 but I want to move the discussion here and decide if we should remove consistent-output from the recommended config in a future major version.

My thoughts:

  • The rule isn't as necessary anymore since ESLint v7 validates that test cases provide output when they produce an autofix
  • It's tedious to include output: null when not necessary
  • Since this rule doesn't autofix, users may end up turning it off rather than manually fix dozens violations, or be scared away from using the plugin entirely
  • To be clear, I'm definitely in favor of rules that can catch issues early even when ESLint itself would also catch the issues. This rule can be helpful in this regard, but "consistency" is an imperfect heuristic. Just because some test cases for a rule have an autofix doesn't mean that all the rule's test cases do, which is why I think it can sometimes be tedious how this rule requires specifying output: null for the non-fixable test cases even though that's already the implicit behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
2 participants