Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3rd party license updater (automation) #92

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix 3rd party license updater (automation) #92

merged 1 commit into from
Feb 22, 2022

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Instead of pushing directly, since the main branch is protected, this creates a pull request.

Failure: https://github.com/erlef/setup-beam/actions/runs/1852644324

It's possible this pull request doesn't pass CI since the 3rd party licenses are outdated, but once it's accepted+merged in at most 24h stuff should be back to normal.

Instead of pushing directly (since the main branch is protected) this creates a pull request
@paulo-ferraz-oliveira
Copy link
Collaborator Author

@starbelly
Copy link
Member

@paulo-ferraz-oliveira It looks this is conflicting with

- name: Check if build left artifacts

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@paulo-ferraz-oliveira It looks this is conflicting with

- name: Check if build left artifacts

It's because the 3rd party licenses are outdated, which is what the pull requests wants to fix 😄 I'd prefer to not fix it here, merge, let the update happen via the action, and then "all's well" (the last time we fixed the files in the pull request, the action ran and failed after merge 😄). After that we can merge the other pull requests, following a rebase...

Let me know, though, if you prefer to do the fix here.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit df03a94 into erlef:main Feb 22, 2022
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Thanks for the approval. I'm merging and running the action in main to see if the pull request gets created. 👍

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/3rd-party-licenses-auto-updates branch February 22, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants