Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Windows'22 container #91

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Allow for Windows'22 container #91

merged 1 commit into from
Feb 22, 2022

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Feb 14, 2022

⚠️ don't merge before #92 and the 3rd party licenses are update (lest we have "expected" errors which don't tell the whole story)

This pull request's goal is to close #90.

I've not tested this locally, so don't expect it to work from the get-go, but let's see...

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@the-mikedavis, this seems to be working: https://github.com/paulo-ferraz-oliveira/setup_beam_example/runs/5189359462?check_suite_focus=true#step:3:10

Care to import my branch to a specific example of yours, test it out and then let us know?

Cheers.

@the-mikedavis
Copy link

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Cool. Let's wait for this to get reviewed and merged and then I'll make a release. @starbelly, could I take a few minutes of you and ask you to review the changes? Thanks much.

@starbelly
Copy link
Member

starbelly commented Feb 20, 2022

Look good. I'll go ahead and merge 🚀

Edit:

n/m, you asked not to merge before #92

(win22 is just a guess, at this moment)
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Rebased on top of main...

@paulo-ferraz-oliveira
Copy link
Collaborator Author

This is all good. Since the recent change was just a rebase (no code changes) and it had @starbelly's approval, I'm going ahead and merging, to allow for further rebase (in other open pull requests).

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit b28629c into erlef:main Feb 22, 2022
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/win22 branch February 22, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows-2022 support
3 participants