Make OTP installation optional

[michallepicki]

closes #79

[paulo-ferraz-oliveira]

@michallepicki, thanks for this. Let me check the changes and get back to you.

[paulo-ferraz-oliveira]

Only a couple minor changes and we're almost there.

[michallepicki]

Not sure what this failure is about? https://github.com/erlef/setup-beam/runs/4762594908?check_suite_focus=true

[paulo-ferraz-oliveira]

Don't worry if the build is only failing for Check if build left artifacts, since this was not introduced by you.

[paulo-ferraz-oliveira]

Not sure what this failure is about? https://github.com/erlef/setup-beam/runs/4762594908?check_suite_focus=true

It's because the 3rd party licenses we're using were updated remotely but not locally (then the action updates them, checks against what you pushed, and errors out).

[paulo-ferraz-oliveira]

I approve the current set of changes. Thanks much for your contribution 👍. I'd like to wait for @starbelly to review this, too, and maybe handle #76 before releasing a new minor.

[starbelly]

@michallepicki You should be able to rebase and we'll get a full passing build.

[starbelly]

This looks good to me, and I mean that :)

Approving with the caveat that the build is still failing.

[starbelly]

Almost forgot, we need documentation for this. It should read clearly this option is currently only applicable to gleam.

[michallepicki]

@starbelly Readme and action.yml updated!

[paulo-ferraz-oliveira]

I left 2 comments and 2 code change suggestions. I'd wondered about the document changes, but had thought making the option visible would only bring more confusion. As is (current pull request), it might not.

[michallepicki]

Rebased from main to resolve conflict

[paulo-ferraz-oliveira]

@michallepicki, so it's easier for me to follow up on what was request/done, resolve conversations only after you push the code changes (or even don't resolve them and let the one who opened them do). 👍

[paulo-ferraz-oliveira]

I'm re-running all actions, after which I think we're good to merge.

[paulo-ferraz-oliveira]

I believe the incomplete action runs are due to us still using ubuntu-16.04, but that's been handled in a different pull request, soon to be merged to main. I'm squash merging this, and once we have all the open pull requests merged and no more action issues we're good to release a new minor. Thanks much.

[paulo-ferraz-oliveira]

Hm... it seems I can't merge since @starbelly has requested changes and these need to be approved (I even tried to remove him as reviewer to speed this up, but no good). We'll have to wait.

[starbelly]