Improve warning message for missing ImageOS env. variable (self-hosted runners) #59
Conversation
src/setup-beam.js
Outdated
| }[process.env.ImageOS] | ||
| } | ||
|
|
||
| function getContainerFromOS() { |
There was a problem hiding this comment.
This is where the guessing game now happens. It's convoluted, sure, but I'm not sure there's a better way to fetch this info. from the target OSs
There was a problem hiding this comment.
See my comment here #58 (comment)
There was a problem hiding this comment.
Per "I'd rather us not start doing guess work around operating systems" I'm reverting this guessing bit. Whatever it is, the self-hosted runner will have to use the ImageOS env. variable to achieve the same behaviour (as suggested by @ericmj). I surely don't want to introduce a new env. variable and that one's already documented in the README.
paulo-ferraz-oliveira
changed the title
| return ImageOSToContainer[process.env.ImageOS] | ||
| if (!containerFromEnvImageOS) { | ||
| throw new Error( | ||
| "Tried to map a target OS from env. variable 'ImageOS', but failed. If you're using a " + |
There was a problem hiding this comment.
Example output:
Tried to map a target OS from env. variable 'ImageOS', but failed. If you're using a self-hosted runner, you should set 'env': 'ImageOS': ... to one of the following: ['ubuntu16', 'ubuntu18', 'ubuntu20', 'win16', 'win19']
There was a problem hiding this comment.
(this way the list will be as updated as the constant definition)
Closes #58.