Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With .../ubuntu-20.04/builds.txt 503'ing error message is out of scope #44

Closed
paulo-ferraz-oliveira opened this issue Jun 8, 2021 · 2 comments · Fixed by #49
Closed

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

The error you get is not from the fact the file is not available, which it should be, but further down the execution, by stating the version is not found in the listing.

When trying to download whatever file or fetching whatever external dependency we shouldn't hide errors behind default return values, meaning we should crash whenever https://github.com/erlef/setup-beam/blob/main/src/setup-beam.js#L272 is invoked.

@josevalim
Copy link

FWIW, there is a fast.ly outage and that may be affecting hex.pm, so we may be seeing error paths that are not common being exercised.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Thanks, José. Yeah, Eric told me about it on Slack.

The issue, for me, is the error message itself. 😄

"Erlang 23.3 not found in version listing" (as-is) vs. "Couldn't fetch version listing. Server returned ..." (as I'd propose for the future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants