Handle strings as such #100
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The values from the YAML aren't really booleans, though they seem like it 😞 |
Closed
|
@paulo-ferraz-oliveira If I understand correctly, why not convert the strings to booleans on the way in so we don't have to do a major version? |
|
We can do that, too, I guess. Let me try it later. (I can't remember, by heart, how it would behave before the change, but can revert it all and try again) |
|
@starbelly, I'm trying your approach... . passed! I'm also removing the license update, since we have this automated now, and working as expected (eg. #95, #97).
|
starbelly
approved these changes
Apr 7, 2022
|
@paulo-ferraz-oliveira Awesome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes one of the issues found via #99 (mis-handling of booleans).
Note: this'll most likely break stuff in-the-wild, since the way the values were being read (
getInput) meant we'd always mixrebarandhex. We can either go with this approach (and bump major) or consider the default should've beentrue, from the start, and change that.