This repository was archived by the owner on Jun 13, 2023. It is now read-only.
feat: override status code with thrown error message #592
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemoshlag
previously approved these changes
Jun 7, 2022
ivojinovic
reviewed
Jun 7, 2022
src/wrappers/lambda.js
Outdated
| @@ -178,7 +178,13 @@ function baseLambdaWrapper( | |||
| message: errorMessage, | |||
| }; | |||
| } | |||
|
|
|||
| // Attempt to extract Status Code from err message. | |||
| const parsedErrMessage = utils.parseRelaxedJSON(reportedError.message); | |||
There was a problem hiding this comment.
Hey I'm sorry, I think I mislead you with what I wrote in the email: not all of our error messages are stringifyed JSON with statusCode - in fact a lot of them are just a string containing 400 or 500. So, I think it would be best if this worked exactly like the mapping in or APIGW IntegrationResponses: by searching the string for a pattern like this .*50[0-9].* or .*40[0-9].*. Ideally, it would be able to capture the exact code (such as 403, or 502 if need be), because sometimes the mappings look for those specific codes and we may want in our traces exactly what the FE will receive
ivojinovic
approved these changes
Jun 7, 2022
ronnathaniel
changed the title
nemoshlag
approved these changes
Jun 8, 2022
|
🎉 This PR is included in version 1.123.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.