Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore local files while pushing an application #2589

Open
devpro opened this issue Sep 21, 2023 · 1 comment
Open

Ignore local files while pushing an application #2589

devpro opened this issue Sep 21, 2023 · 1 comment
Labels
kind/bug Something isn't working
Milestone
v1.12.0

Comments

@devpro
Copy link

devpro commented Sep 21, 2023 •
edited

Describe the bug
I can't push my application while developing it. I have a generic error because epinio is pushing everything from the application directory (except git files and directories if I understand correctly https://github.com/epinio/epinio/blob/main/helpers/tar.go).

To Reproduce
Steps to reproduce the behavior, e.g.:

  1. Have an Epinio server and Epinio CLI installed and connected to the server
  2. Create a NPM based application (like Angular or React) or use an example (like https://github.com/devpro/epinio-samples or https://github.com/paketo-buildpacks/samples) and do npm install in the sample folder
  3. Try to push the application with 'epinio push --name ngsample --path ngsample'
  4. See error

Expected behavior
The developer should have an easy way to set the files to be ignored by epinio while pushing the application (specific ignore file or in the epinio.yaml config file) and/or epinio should look at the .gitignore files.
Also we should make sure we garantee the integrity of the code that is pushed and avoid strange behavior, like a build artifact complied locally that would be used to generate the artifact.

Logs

2023/09/21 09:14:44 EpinioApiClient: "msg"="decoding json error" "error"="invalid character '<' looking for beginning of value" "body"="<html>\r\n<head><title>413 Request Entity Too Large</title></head>\r\n<body>\r\n<center><h1>413 Request Entity Too Large</h1></center>\r\n<hr><center>nginx</center>\r\n</body>\r\n</html>\r\n"
2023/09/21 09:14:44 EpinioClient/Push: "level"=4 "msg"="return" "Name"="ngsample" "Namespace"="workspace" "Sources"="C:\\Users\\BertrandThomas\\workspace\\devpro\\epinio-samples\\samples\\angular\\ngsample"

Cluster (please complete the following information):

  • Provider: AKS
  • Options: 2 worker nodes
  • Kubernetes Version: 1.24

Desktop/CLI (please complete the following information):

  • OS: Windows 10
  • Epinio Version: 1.9.0
  • Epinio Install Options: Helm, cert-manager, Let's Encrypt (Production cluster issuer), sslip.io

Additional context
This is really important for the Developer Experience.
To deploy in Production, yes epinio push should run from a neutral environment without the local build artifacts.
But for many usecases we may want to push the application we are working on.
This is important also to reduce the bandwidth and ensure the quality of the code that is sent (could even maybe interesting to have a git status check to make sure that for prod we don't sent code with pending changes).
Also, to promote Epinio I would like to show how easy to go from my machine to a running instance.
@devpro devpro added the kind/bug Something isn't working label Sep 21, 2023
@richard-cox
Copy link
Member

Linking #1646.

Follow on work for the UI epinio/ui#147

@richard-cox richard-cox mentioned this issue Aug 9, 2022
Open
@enrichman enrichman added this to the v1.12.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
Epinio planning
Status: Scheduled
Milestone
v1.12.0
Development

No branches or pull requests
3 participants
@devpro @enrichman @richard-cox