Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(VaSelect): improvement objects as options description(#4067) #4206

Merged
merged 1 commit into from
Apr 8, 2024
Merged

docs(VaSelect): improvement objects as options description(#4067) #4206

merged 1 commit into from
Apr 8, 2024

Conversation

gweesin
Copy link
Contributor

@gweesin gweesin commented Apr 4, 2024

Description

closed #4067

Recommend using track-by to prevent object reference issues when using objects as options.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

m0ksem
m0ksem approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Thanks.

@m0ksem m0ksem added the docs packages/docs label Apr 8, 2024
@m0ksem m0ksem merged commit 37aac3a into epicmaxco:develop Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(Select): add text about track-by usage
2 participants
@gweesin @m0ksem