ci: build dyplomat as part of CI #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though dyplomat has no tests, we should still add it to CI to get a signal when dependabot wants to update the Go dependencies. We just want to know whether it still builds. Signed-off-by: James Peach <jpeach@apache.org>
sunjayBhatia
approved these changes
May 23, 2023
Yeh it would probably be worth doing that. We are already in a Docker container in this CI job though, so we probably want a different approach to verify it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though dyplomat has no tests, we should still add it to CI to get a signal when dependabot wants to update the Go dependencies. We just want to know whether it still builds.