Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.13.2 broke dependency upgrades for cloud.google.com/go/storage #1074

Closed
abh opened this issue Dec 23, 2024 · 1 comment · Fixed by #1075
Closed

v0.13.2 broke dependency upgrades for cloud.google.com/go/storage #1074

abh opened this issue Dec 23, 2024 · 1 comment · Fixed by #1075

Comments

@abh
Copy link

abh commented Dec 23, 2024

The change in #714 (released in v0.13.2) seems to have broken dependency upgrades for the google cloud Go packages (see googleapis/google-cloud-go#11283 (comment)).

workaround:

go mod edit --exclude=github.com/envoyproxy/go-control-plane@v0.13.2
@tritone tritone mentioned this issue Dec 23, 2024
Closed
valerian-roche added a commit that referenced this issue Dec 24, 2024
@valerian-roche
Add imports of previous root package in new subpackages to avoid depe…
Loading
Loading status checks…
4e25fcd 
…ndency upgrade issues.

Those changes are based on https://go.dev/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository

Fixes #1074

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
@valerian-roche valerian-roche mentioned this issue Dec 24, 2024
Merged
valerian-roche added a commit that referenced this issue Dec 24, 2024
@valerian-roche
Add imports of previous root package in new subpackages to avoid depe…
Loading
Loading status checks…
496e667 
…ndency upgrade issues.

Those changes are based on https://go.dev/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository

Fixes #1074

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
felixfontein added a commit to felixfontein/sops that referenced this issue Dec 25, 2024
@felixfontein
Update all dependencies with 'go get -t -u ./...'.
67e3cec 
Needed 'go mod edit --exclude=github.com/envoyproxy/go-control-plane@v0.13.2' to succeed.
Ref: envoyproxy/go-control-plane#1074

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein mentioned this issue Dec 25, 2024
Merged
felixfontein added a commit to felixfontein/sops that referenced this issue Dec 25, 2024
@felixfontein
Update all dependencies with 'go get -t -u ./...'.
61e8ff1 
Needed 'go mod edit --exclude=github.com/envoyproxy/go-control-plane@v0.13.2' to succeed.
Ref: envoyproxy/go-control-plane#1074

Signed-off-by: Felix Fontein <felix@fontein.de>
@jsoriano jsoriano mentioned this issue Dec 26, 2024
Closed
@katexochen
Copy link

workaround:

go mod edit --exclude=github.com/envoyproxy/go-control-plane@v0.13.2

This didn't solve the issue for me, as go would just select a lower version of go-control-plane (v0.13.1), which still has ambiguous import paths.

I used the following to point go to the latest version of the main module, even if my go.mod doesn't require the module:

replace github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.13.2

@mmorel-35 mmorel-35 mentioned this issue Dec 30, 2024
Merged
@serprex serprex mentioned this issue Dec 31, 2024
Merged
1 task
valerian-roche added a commit that referenced this issue Jan 3, 2025
@valerian-roche @update-envoy
Add imports of previous root package in new subpackages to avoid depe…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4b91141 
…ndency upgrade issues.

Those changes are based on https://go.dev/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository

Fixes #1074

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
@valerian-roche valerian-roche mentioned this issue Jan 3, 2025
Closed
@mathieu-lemay mathieu-lemay mentioned this issue Jan 6, 2025
Closed
josephschorr added a commit to authzed/spicedb that referenced this issue Feb 16, 2025
@josephschorr
Fix for envoyproxy/go-control-plane#1074 and tidy go mod
Loading
Loading status checks…
2516063
marensofier pushed a commit to marensofier/sops that referenced this issue Mar 5, 2025
@felixfontein
Update all dependencies with 'go get -t -u ./...'.
7485e4e 
Needed 'go mod edit --exclude=github.com/envoyproxy/go-control-plane@v0.13.2' to succeed.
Ref: envoyproxy/go-control-plane#1074

Signed-off-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abh @katexochen