Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: envelope-zero/backend
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.2
Choose a base ref
...
head repository: envelope-zero/backend
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.3
Choose a head ref
  • 6 commits
  • 6 files changed
  • 2 contributors

Commits on Jan 3, 2025

  1. chore(deps): update dependency golangci/golangci-lint to v1.63.4 (#1119)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 3, 2025
    Copy the full SHA
    fdf5be3 View commit details

Commits on Jan 21, 2025

  1. chore(deps): update actions/setup-go action to v5.3.0 (#1121)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 21, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f53a1ff View commit details

Commits on Jan 22, 2025

  1. chore(deps): update codecov/codecov-action action to v5.2.0 (#1122)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 22, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    aaad742 View commit details

Commits on Jan 23, 2025

  1. chore(deps): update codecov/codecov-action action to v5.3.0 (#1123)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 23, 2025
    Copy the full SHA
    f1df766 View commit details

Commits on Jan 24, 2025

  1. chore(deps): update codecov/codecov-action action to v5.3.1 (#1124)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 24, 2025
    Copy the full SHA
    a2401db View commit details

Commits on Jan 25, 2025

  1. fix: set availableFrom to next month for imports (#1125)

    morremeyer authored Jan 25, 2025
    Copy the full SHA
    86b6eee View commit details
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
- uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
with:
go-version: 1.23.4

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ jobs:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
with:
go-version: 1.23.4

4 changes: 2 additions & 2 deletions .github/workflows/test-and-tag.yml
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Set up go
uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
with:
# renovate: go-version
go-version: 1.23.4
@@ -27,7 +27,7 @@ jobs:
go test ./... -race -covermode=atomic -coverprofile=coverage.out
- name: Upload coverage to Codecov
uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303 # v5.1.2
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
with:
files: coverage.out

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.PHONY: setup-pre-commit-ci
setup-pre-commit-ci:
# renovate: datasource=github-releases depName=golangci/golangci-lint
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.63.3
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.63.4
# renovate: datasource=github-releases depName=swaggo/swag
go install github.com/swaggo/swag/cmd/swag@v1.16.4

4 changes: 2 additions & 2 deletions internal/controllers/v4/import_test.go
Original file line number Diff line number Diff line change
@@ -223,9 +223,9 @@ func (suite *TestSuiteStandard) TestImportYnabImportPreviewAvailableFrom() {
preview := suite.parseCSV(suite.T(), account.Data.ID, "available-from-test.csv")

dates := []types.Month{
types.NewMonth(2019, 2),
types.NewMonth(2019, 4),
types.NewMonth(2019, 3),
types.NewMonth(2019, 5),
types.NewMonth(2019, 6),
}

for i, transaction := range preview.Data {
11 changes: 7 additions & 4 deletions internal/importer/parser/ynab-import/parse.go
Original file line number Diff line number Diff line change
@@ -56,10 +56,13 @@ func Parse(f io.Reader, account models.Account) ([]importer.TransactionPreview,

t := importer.TransactionPreview{
Transaction: models.Transaction{
Date: date,
AvailableFrom: types.NewMonth(date.Year(), date.Month()),
ImportHash: helpers.Sha256String(strings.Join(record, ",")),
Note: record[headers["Memo"]],
Date: date,
ImportHash: helpers.Sha256String(strings.Join(record, ",")),
Note: record[headers["Memo"]],

// AvailableFrom is only used for income transactions, for which it defaults to the month after the transaction.
// Since it is only used for income transactions, we can safely set it here.
AvailableFrom: types.NewMonth(date.Year(), date.Month()).AddDate(0, 1),
},
}