Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeResolved and nodeImported in ImportNodesParams and ExportNodesParams should be optional #10409

Closed
alansemenov opened this issue Feb 6, 2024 · 0 comments · Fixed by #10410
Assignees
Labels
Milestone

Comments

@alansemenov
Copy link
Member

These properties are currently mandatory and have to be specified for every import/export, even if you don't care about the number of resolved/imported nodes.

    const nodes = importNodes({
        source: resolve('/import'),
        targetNodePath: '/content',
        xslt: resolve('/import/replace_app.xsl'),
        xsltParams: {
            applicationId: app.name
        },
        includeNodeIds: true,
        nodeImported: () => {},
        nodeResolved: () => {}
    });

They should be optional. They are already correctly defined as nullable in the jsdoc definitions and the java beans.

@alansemenov alansemenov self-assigned this Feb 6, 2024
@alansemenov alansemenov added the Bug label Feb 6, 2024
alansemenov added a commit that referenced this issue Feb 6, 2024
alansemenov added a commit that referenced this issue Feb 7, 2024
alansemenov added a commit that referenced this issue Feb 23, 2024
…ams should be optional #10409

(cherry picked from commit dce198d)
@rymsha rymsha added this to the 7.14.1 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants