add a proxy method to access bitstream extension #1631
Merged
+48
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generic_platform add a method to return extension for sram/flash vendor platform: bitstream_ext -> _bitstream_ext and replace by a dict when extension depends on mode builder: use `get_bitstream_extension` instead of directly using bitstream_ext
|
Thanks @trabucayre! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting bitstream's filename the current behaviour for soc/integration/builder is to use directly
soc.platform.bitstream_extfor sram mode and returning bin for flash. This imply, at targets level, for flash mode, to useget_bitstream_filename's ext parameter to force correct extension.This PR add, at build/generic_platform a method to return extension according to
mode(may be the same extension for both case when build/vendor/platform.py declare_bitstream_extas a string or two different extension when_bitstream_extis a dict).This also fix extension for anlogic (fs is for gowin FPGA).