Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop matrix from the lint job #2283

Open
turadg opened this issue May 13, 2024 · 0 comments
Open

drop matrix from the lint job #2283

turadg opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented May 13, 2024

What is the Problem Being Solved?

The lint job does static analysis, but it's configured to run against multiple Node runtimes. Only one is needed and it shouldn't have a matrix because that necessitates updating its Required check when bumping Node versions.

Description of the Design

  1. Take the matrix out of

    name: lint
    # begin macro
    runs-on: ${{ matrix.platform }}
    strategy:
    fail-fast: false
    matrix:
    node-version: [18.x, 20.x]
    platform: [ubuntu-latest]

  2. A repo admin updates settings to require the plain "lint" job, not the runtime-scoped one

Security Considerations

Scaling Considerations

Test Plan

Compatibility Considerations

Upgrade Considerations

@turadg turadg added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant