Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade mkdocs-material #2229

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Downgrade mkdocs-material #2229

merged 1 commit into from
Jan 25, 2024

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jan 24, 2024 •
edited

I need this to fix the docs...

@Kludex Kludex requested review from tomchristie and a team January 24, 2024 22:45
frankie567
frankie567 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@frankie567 frankie567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@Kludex Kludex merged commit bcde07d into master Jan 25, 2024
15 checks passed
@Kludex Kludex deleted the downgrade-mkdocs-material branch January 25, 2024 13:32
@tomchristie
Copy link
Member

Do we know how this regression was introduced in mkdocs or mkdocs-material?
Is there an open issue?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jan 25, 2024 •
edited

No, there's no issue, and I didn't investigate it.

I also can't reproduce locally with uvicorn.

(an issue would be nice)

@frankie567 frankie567 mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankie567 frankie567 frankie567 approved these changes

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @tomchristie @frankie567