Revert "Turn scope["client"] to None on TestClient (#2377)"
#2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 483849a.
aminalaee
force-pushed
the
revert-testclient-scope-2377
branch
from
14b62d3
to
d6eabb0
Compare
Let's try to find another solution for that problem. It looks like removing the client brought more unsatisfaction than happiness. |
Kludex
approved these changes
Feb 29, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Mar 18, 2024
…" (encode#2525) * Revert "Turn `scope["client"]` to `None` on `TestClient` (encode#2377)" This reverts commit 483849a. * format * Add type hints --------- Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
tomclement
added a commit
to ThoughtWorks-DPS/hello-restful
that referenced
this pull request
Mar 23, 2024
inglor
pushed a commit
to archlinux/aurweb
that referenced
this pull request
Apr 8, 2024
TestClient changes were reverted with 0.37.2: encode/starlette#2525 https://github.com/encode/starlette/releases/tag/0.37.2 Signed-off-by: moson <moson@archlinux.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 483849a.
Summary
Checklist