Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mypy skip flags #2497

Merged
merged 3 commits into from Feb 9, 2024
Merged

Remove mypy skip flags #2497

merged 3 commits into from Feb 9, 2024

Conversation

TechNiick
Copy link
Contributor

Summary

This PR is related to this issue.
This is the final PR, deleted the flags.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@TechNiick TechNiick changed the title Remove flags Remove mypy skip flags Feb 9, 2024
Kludex
Kludex reviewed Feb 9, 2024
View reviewed changes
scripts/check Show resolved Hide resolved
Kludex
Kludex requested changes Feb 9, 2024
View reviewed changes
pyproject.toml Outdated
# module = "tests.*"
# disallow_untyped_defs = false
# check_untyped_defs = true
[[tool.mypy.overrides]]
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete those.

@Kludex
Copy link
Sponsor Member

Kludex commented Feb 9, 2024

Thanks for your work on all the test files @TechNiick 🙏

@Kludex Kludex enabled auto-merge (squash) February 9, 2024 21:38
@Kludex Kludex merged commit f724827 into encode:master Feb 9, 2024
5 checks passed
@TechNiick
Copy link
Contributor Author

TechNiick commented Feb 10, 2024 •
edited

Thanks for your work on all the test files @TechNiick 🙏

Thank you for guidance!

nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
@TechNiick @Kludex
Remove mypy skip flags (encode#2497)
113b544 
* Remove flags

* Apply suggestions from code review

* Remove mypy overrides

---------

Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TechNiick @Kludex