Add type hints to test_testclient.py
#2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Feb 7, 2024
tests/test_testclient.py
Outdated
| from contextlib import asynccontextmanager | ||
| from typing import Callable | ||
| from typing import Any, AsyncGenerator, Awaitable, Callable, Union |
There was a problem hiding this comment.
Remove Any, please.
Use | instead of Union.
There was a problem hiding this comment.
In this file, Any is used only here:
def current_task() -> Task[Any] | trio.lowlevel.Task:
I couldn't figure it out what type should be there instead of Any. Could you help me on this one please?
Kludex
approved these changes
Feb 9, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Mar 18, 2024
* Add type hints to test_testclient.py * Fix check errors * Apply suggestions from code review * Use ASGIInstance instead --------- Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to this
Type annotation added to
test_testclient.pyChecklist