Add type hints to test_responses.py
#2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Feb 7, 2024
Kludex
approved these changes
Feb 7, 2024
auto-merge was automatically disabled
February 7, 2024 19:24
Head branch was pushed to by a user without write access
Kludex
requested changes
Feb 7, 2024
tests/test_responses.py
Outdated
| async def app(scope, receive, send): | ||
| async def numbers(minimum, maximum): | ||
| async def app(scope: Scope, receive: Receive, send: Send) -> None: | ||
| async def numbers(minimum: int, maximum: int) -> AsyncGenerator[str, None]: |
There was a problem hiding this comment.
Suggested change
| async def numbers(minimum: int, maximum: int) -> AsyncGenerator[str, None]: | |
| async def numbers(minimum: int, maximum: int) -> AsyncIterator[str]: |
tests/test_responses.py
Outdated
| nonlocal streamed | ||
| if message["type"] == "http.response.body": | ||
| streamed += len(message.get("body", b"")) | ||
| # Simulate disconnection after download has started | ||
| if streamed >= 16: | ||
| disconnected.set() | ||
|
|
||
| async def stream_indefinitely(): | ||
| async def stream_indefinitely() -> AsyncGenerator[bytes, None]: |
There was a problem hiding this comment.
Suggested change
| async def stream_indefinitely() -> AsyncGenerator[bytes, None]: | |
| async def stream_indefinitely() -> AsyncIterator[bytes]: |
added 2 commits
February 7, 2024 22:22
…tarlette into improve-types/test_responses
Kludex
approved these changes
Feb 9, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Mar 18, 2024
* Add type hints to test_responses.py * Update tests/test_responses.py * Linter fix * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to this
Type annotation added to
test_responses.pyChecklist