Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] broken link to "see also: request instances" #3157

Closed
jakkdl opened this issue Apr 3, 2024 · 1 comment
Closed

[docs] broken link to "see also: request instances" #3157

jakkdl opened this issue Apr 3, 2024 · 1 comment

Comments

@jakkdl
Copy link

jakkdl commented Apr 3, 2024

If you go to https://www.python-httpx.org/api/#client, scroll down to the documentation for build_request (being able to directly link the method would be nice...), and try to click on "See also: Request instances" you're hit with an error 404.

build_request(self, method, url, *, content=None, data=None, files=None, json=None, params=None, headers=None, cookies=None, timeout=, extensions=None)

Build and return a request instance.

The params, headers and cookies arguments are merged with any values set on the client.
The url argument is merged with any base_url set on the client.

See also: Request instances

Skipping creating a discussion over this, as clearly you don't want broken links in your docs.

@alexdlukens
Copy link

alexdlukens commented Apr 3, 2024

Looks like the links were corrected in #3123 on Feb 29, but the docs have not been rebuilt since Feb 21 (#3095). A redeploy of the docs should fix this

@encode encode locked and limited conversation to collaborators Apr 4, 2024
@tomchristie tomchristie converted this issue into discussion #3158 Apr 4, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants