Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff error and script #2680

Merged
merged 3 commits into from Apr 26, 2023
Merged

Fix ruff error and script #2680

merged 3 commits into from Apr 26, 2023

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Apr 25, 2023 •
edited

Summary

The ruff command in ./scripts/check is not catching the errors, but running ./scripts/lint does.
This PR will fix both ruff command and the bare exception issue.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@aminalaee aminalaee requested a review from a team April 25, 2023 10:27
@aminalaee
Copy link
Member Author

I have created the issue to see what if the ruff command needs to be changed: astral-sh/ruff#4093
But anyway the exception handling should be fixed.

abersheeran
abersheeran approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@abersheeran abersheeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Apr 25, 2023
Merged
Merged
aminalaee
aminalaee commented Apr 25, 2023
View reviewed changes
httpx/_utils.py Outdated Show resolved Hide resolved
@aminalaee aminalaee merged commit 32e2549 into encode:master Apr 26, 2023
5 checks passed
@aminalaee aminalaee deleted the fix-ruff-error branch April 26, 2023 13:20
@karpetrosyan karpetrosyan mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex left review comments

@michaeloliverx michaeloliverx michaeloliverx left review comments

@abersheeran abersheeran abersheeran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aminalaee @Kludex @abersheeran @michaeloliverx