Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional percent encoding behaviour. #2671

Merged
merged 5 commits into from Apr 19, 2023
Merged

Fix optional percent encoding behaviour. #2671

merged 5 commits into from Apr 19, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Apr 19, 2023 •
edited

Closes #2670

  • Tests for failing optional percent encoding.
  • Fix for failing optional percent encoding.

@tomchristie tomchristie added the bug Something isn't working label Apr 19, 2023
@tomchristie tomchristie requested a review from a team April 19, 2023 11:25
@tomchristie tomchristie merged commit 9ae170a into master Apr 19, 2023
5 checks passed
@tomchristie tomchristie deleted the fix-optional-percent-escaping branch April 19, 2023 12:21
@epenet epenet mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percent sign not encoded when present in query params value
2 participants
@tomchristie @aminalaee