GitHub Actions: Upgrade pre-commit and drop the removed token #9267
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* https://github.com/pre-commit/action/releases * https://github.com/actions/checkout/releases * https://github.com/actions/setup-python/releases https://github.com/pre-commit/action#using-this-action-in-private-repositories explains why `token` was removed but is a bit difficult to understand. Moving to running pre-commit on https://pre-commit.ci has proved to be the best solution on other projects.
auvipy
reviewed
Feb 28, 2024
| - uses: pre-commit/action@v3.0.0 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| - uses: pre-commit/action@v3.0.1 |
There was a problem hiding this comment.
The first URL of the commit message explains that we were being warned that we were misusing @v3.0.0
The second URL of the commit message explains that pre-commit/action was upgraded to properly deal with the token. https://docs.github.com/en/actions/security-guides/automatic-token-authentication
The fifth URL of the commit message points to the Action author's explanation of why the repo was unarchived to make the v3.0.1 change.
auvipy
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some warnings at the bottom right of https://github.com/encode/django-rest-framework/actions/runs/8079303418
https://github.com/pre-commit/action#using-this-action-in-private-repositories explains why
tokenwas removed but is a bit difficult to understand.Moving to running pre-commit on https://pre-commit.ci has proved to be the best solution on other projects.
Note: Before submitting this pull request, please review our contributing guidelines.
Description
Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use
refs #...in the description of the pull request.