Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made api_setting.UNICODE_JSON/ensure_ascii affecting json schema #7991

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Made api_setting.UNICODE_JSON/ensure_ascii affecting json schema #7991

merged 1 commit into from
Dec 8, 2021
+8 −2

Conversation

meteozond
Copy link
Contributor

We've noticed that UNICODE_JSON setting doesn't affect schema json.
But this suppose to be useful.
This PR makes CoreAPIJSONOpenAPIRenderer and OpenAPIRenderer behave as JSONRenderer.

tomchristie
tomchristie approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@tomchristie tomchristie merged commit b0d407f into encode:master Dec 8, 2021
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@meteozond @sigvef
Made api_setting.UNICODE_JSON/ensure_ascii affecting json schema (enc…

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
6c237e0 
…ode#7991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meteozond @tomchristie