Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests with in-memory SQLite databases #569

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Aug 28, 2023

Closes #567 by ensuring garbage collection is run consistently to prevent flakes where the in-memory SQLite database is not dropped.

@zanieb zanieb changed the title Run garbage collection before asserting SQLite database is cleared in test Fix flaky tests with in-memory SQLite databases Aug 29, 2023
@zanieb zanieb added the clean up Refinement to existing functionality label Aug 29, 2023
@zanieb zanieb requested a review from Kludex August 29, 2023 21:27
@zanieb zanieb merged commit d047d40 into master Aug 30, 2023
4 checks passed
@zanieb zanieb deleted the fix/test-ref-drop branch August 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Refinement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New test test_should_remove_ref_on_disconnect in 0.8.0 fails on Fedora Linux
2 participants