Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

GeniusReader loader #819

Merged
merged 10 commits into from
Feb 7, 2024
Merged

GeniusReader loader #819

merged 10 commits into from
Feb 7, 2024

Conversation

ThibaudARoy
Copy link
Contributor

@ThibaudARoy ThibaudARoy commented Dec 28, 2023

Description

Added GeniusReader loader, which allows for loading of documents from the Genius API

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

@nerdai
Copy link
Contributor

nerdai commented Jan 3, 2024

Thanks for the contribution @ThibaudARoy. Looks like test our failing due to import errors. Can you follow a similar pattern to whats been used in the past, which is to do lazy imports and throw an error if the module is not installed?

See here:

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move lyricsgenious import statement

from typing import List, Optional
from llama_index.readers.base import BaseReader
from llama_index.readers.schema.base import Document
import lyricsgenius
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment in main conversation thread. Can we move this into the init of the class?

@jerryjliu
Copy link
Collaborator

@ThibaudARoy is there an update on this?

@ThibaudARoy
Copy link
Contributor Author

@jerryjliu updated the import statement. Let me know if there's anything else I can fix.

@jerryjliu
Copy link
Collaborator

sorry for delay @ThibaudARoy seems like there's some minor linting errors you can fix with make lint; make format!

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay on this

@jerryjliu jerryjliu merged commit 5263112 into run-llama:main Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants