Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

Updated Docugami loader #771

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

tjaffri
Copy link
Contributor

@tjaffri tjaffri commented Dec 14, 2023

Description

Updates the Docugami loader to use the dgml-utils library for XML parsing, removing a lot of code from the loader (and with lots of parsing improvements we are separately maintaining in dgml-utils.

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tjaffri tjaffri changed the title Updated Docugami loader, and pack Updated Docugami loader Feb 7, 2024
@tjaffri tjaffri marked this pull request as ready for review February 7, 2024 19:01
@jerryjliu jerryjliu merged commit be02528 into run-llama:main Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants