Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspectRatio property is made unitless #3012

Merged
merged 4 commits into from May 4, 2023
Merged

Conversation

sgrishchenko
Copy link
Contributor

What:

aspectRatio property is made unitless

Why:

It fixes #3011

How:

aspectRatio property is just marked as unitless

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 5a07e60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/unitless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a07e60:

Sandbox Source
Emotion Configuration
Aspect Ratio Emotion Issue Issue #3011

@emmatown emmatown merged commit e6e5b3d into emotion-js:main May 4, 2023
15 checks passed
@github-actions github-actions bot mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set a number value for aspect-ratio
2 participants