Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Rename Rounding to CornerRadius #5673

Merged
merged 7 commits into from
Feb 4, 2025
Merged

⚠️ Rename Rounding to CornerRadius #5673

merged 7 commits into from
Feb 4, 2025
+378 −330

Conversation

emilk
Copy link
Owner

@emilk emilk commented Feb 4, 2025

Breaking change!

  • Rounding -> CornerRadius
  • rounding -> corner_radius

This is to:

  • Clarify
  • Conform to other systems (e.g. Figma)
  • Avoid confusion with GuiRounding

emilk added 2 commits February 4, 2025 11:44
@emilk
Rename Rounding to CornerRadius

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
GPG key ID: 81C63AE1C224182B
Verified
Learn about vigilant mode
c5d8839
@emilk
Use integer rounding everywhere
4729073
emilk added 3 commits February 4, 2025 11:51
@emilk
Fixes
0ad6454
@emilk
Fix doclinks
f0c5226
@emilk
Update snapshot tests: labels changed from "Rounding" to "Corner radius"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8edbbe1
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Preview available at https://egui-pr-preview.github.io/pr/5673-emilkcornerradius
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

lucasmerlin
lucasmerlin approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

emilk added 2 commits February 4, 2025 12:40
@emilk
Add a deprecated type alias to ease migration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
042725e
@emilk
Add deprecated WidgetVisuals::rounding to ease migration

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
GPG key ID: 81C63AE1C224182B
Verified
Learn about vigilant mode
cba3571
@emilk emilk merged commit 23ed493 into master Feb 4, 2025
46 checks passed
@emilk emilk deleted the emilk/corner_radius branch February 4, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmerlin lucasmerlin

Assignees
No one assigned
Labels
egui epaint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @lucasmerlin