Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call wgpu paint callback if viewport is positive #3778

Merged
merged 1 commit into from Jan 8, 2024
Merged

Only call wgpu paint callback if viewport is positive #3778

merged 1 commit into from Jan 8, 2024

Conversation

msparkles
Copy link
Contributor

Closes #3759

@emilk emilk added the egui-wgpu label Jan 8, 2024
@emilk emilk merged commit b087f58 into emilk:master Jan 8, 2024
19 of 20 checks passed
@emilk emilk changed the title fix egui-wgpu callback viewport size check (#3759) Check that viewport is positive before calling wgpu paint callback (#3759) Jan 8, 2024
@emilk emilk changed the title Check that viewport is positive before calling wgpu paint callback (#3759) Check viewport is positive before calling wgpu paint callback (#3759) Jan 8, 2024
@emilk emilk changed the title Check viewport is positive before calling wgpu paint callback (#3759) Only call wgpu paint callback if viewport is positive Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui-wgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viewport out-of-range when first constructing certain UIs rendered with egui-wgpu callbacks
2 participants
@msparkles @emilk