Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more links to the source code in the egui demo #3770

Merged
merged 1 commit into from Jan 8, 2024

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Jan 5, 2024

@c-git
Copy link
Contributor Author

c-git commented Jan 5, 2024

Please let me know if screenshot are needed. Not sure if it's worth the effort.

@c-git
Copy link
Contributor Author

c-git commented Jan 5, 2024

Tried to run the check script but it can't run as is. See error below.

$ ./scripts/check.sh 
+ cargo install --quiet cargo-cranky
+ cargo install --quiet typos-cli
error: failed to compile `typos-cli v1.17.0`, intermediate artifacts can be found at `/tmp/cargo-installOumziI`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  package `varcon-core v4.0.4` cannot be built because it requires rustc 1.75 or newer, while the currently active rustc version is 1.72.0
  Try re-running cargo install with `--locked`

@c-git c-git marked this pull request as ready for review January 5, 2024 04:42
@ryo33
Copy link

ryo33 commented Jan 8, 2024

@c-git I've temporarily modified the rust-toolchain.toml to use the Rust version 1.75.0, and reverted it after ./scripts/check.sh, and re-run ./scripts/check.sh, and it works as a workaround of this error in my PR. I don't know if should I open an issue or PR for this error.

@c-git
Copy link
Contributor Author

c-git commented Jan 8, 2024

That's fair, I guessed it was something like that but didn't have the time to check it.

@c-git
Copy link
Contributor Author

c-git commented Jan 8, 2024

I feel like since the PR would be small should be easy enough to do and get feedback on.

@emilk emilk added the docs and examples Improving and adding documentation and examples label Jan 8, 2024
@emilk emilk merged commit b0c7a7f into emilk:master Jan 8, 2024
19 of 20 checks passed
@emilk
Copy link
Owner

emilk commented Jan 8, 2024

Thanks!

@emilk emilk changed the title Add missing links to source code Add more links to the source code in the egui demo Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and examples Improving and adding documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants