Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple samples for Write, issue #514 #515

Merged
merged 20 commits into from
Aug 5, 2023
Merged

allow multiple samples for Write, issue #514 #515

merged 20 commits into from
Aug 5, 2023

Conversation

emicklei
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #515 (408f75a) into v3 (ec34605) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v3     #515      +/-   ##
==========================================
+ Coverage   69.52%   69.75%   +0.22%     
==========================================
  Files          28       28              
  Lines        1608     1610       +2     
==========================================
+ Hits         1118     1123       +5     
+ Misses        415      412       -3     
  Partials       75       75              
Impacted Files Coverage Δ
route.go 85.07% <ø> (ø)
route_builder.go 73.37% <100.00%> (+2.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SVilgelm
Copy link
Contributor

SVilgelm commented Mar 2, 2023

same about readSamples :)
we have bunch of endpoints that can work with the different types, like a general create api where is a type of object is a field in payload :)))

@emicklei
Copy link
Owner Author

emicklei commented Mar 2, 2023

same about readSamples :)
we have bunch of endpoints that can work with the different types, like a general create api where is a type of object is a field in payload :)))

that should be an easy addition to this PR.

@emicklei emicklei merged commit bdefcac into v3 Aug 5, 2023
@emicklei emicklei deleted the feature/issue514 branch August 5, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants