Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some org.embulk.* packages from "parent_first" #1684

Merged

Conversation

dmikurube
Copy link
Member

This is the goal of #1682 and #1683.

Some packages under "org.embulk." are intentionally excluded from "parent_first", for example,

  • Packages for plugins, such as "org.embulk.input." and "org.embulk.parser."
  • Packages under "org.embulk.base.", "org.embulk.deps.", and "org.embulk.util."

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dmikurube dmikurube added this to the v0.11.5 milestone Sep 12, 2024
@dmikurube dmikurube requested a review from a team as a code owner September 12, 2024 08:05
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit c7ad1ab into master Sep 12, 2024
16 checks passed
@dmikurube dmikurube deleted the exclude-some-org.embulk-packages-from-parent_first branch September 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants