Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: emberstack/kubernetes-reflector
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.1.20
Choose a base ref
...
head repository: emberstack/kubernetes-reflector
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.1.23
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 9, 2022

  1. Added startupProbe to chart (#253)

    The startupProbe only applies to K8s >= v1.18.
    
    Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
    jlsalvador authored Jan 9, 2022
    Copy the full SHA
    527db4e View commit details
Showing with 12 additions and 0 deletions.
  1. +8 −0 src/helm/reflector/templates/deployment.yaml
  2. +4 −0 src/helm/reflector/values.yaml
8 changes: 8 additions & 0 deletions src/helm/reflector/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -54,6 +54,14 @@ spec:
port: http
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
{{- if semverCompare ">= 1.18-0" .Capabilities.KubeVersion.Version }}
startupProbe:
httpGet:
path: /healthz
port: http
failureThreshold: {{ .Values.startupProbe.failureThreshold }}
periodSeconds: {{ .Values.startupProbe.periodSeconds }}
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- with .Values.nodeSelector }}
4 changes: 4 additions & 0 deletions src/helm/reflector/values.yaml
Original file line number Diff line number Diff line change
@@ -51,6 +51,10 @@ livenessProbe:
readinessProbe:
initialDelaySeconds: 5
periodSeconds: 10
startupProbe:
# The application will have a maximum of 50s (10 * 5 = 50s) to finish its startup.
failureThreshold: 10
periodSeconds: 5

resources:
{}