@ember/test-helpers rendering test broke on canary after #20570 #20576
Comments
chancancode
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere.
chancancode
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
chancancode
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
chancancode
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported by @ijlee2 https://github.com/ijlee2/embroider-css-modules/actions/runs/6891050277
Background:
TemplateFactoryis(owner) => Templatetemplatefield onOutletStatewas always meant to be aTemplate@ember/test-helpersused the internal API incorrectly and passes aTemplateFactoryin place of aTemplateThe text was updated successfully, but these errors were encountered: