fix progress-bar transition aborted #453
Merged
+150
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
fix-progress-bar
branch
from
e88382d to
212b815
Compare
mansona
force-pushed
the
fix-progress-bar
branch
from
22a8ca3 to
719f033
Compare
nickschot
approved these changes
Mar 31, 2023
|
Some tests with 'continue-on-error: true' have failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was a change in ember-concurrency that was causing progress-bar to throw a TransitionAborted error. I didn't really find the cause of the problem but removing the complicated code that accessed the transition's internal promise seemed to fix the issue.