Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #422

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Fix CI #422

merged 4 commits into from
Mar 6, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented May 13, 2022

This is testing out ember-cli/ember-try#850 to try and solve the problem that is described in emberjs/ember-render-modifiers#64 👍

@mansona mansona force-pushed the fix-ci branch 2 times, most recently from ffc6300 to 139571f Compare May 13, 2022 15:10

Verified

This commit was signed with the committer’s verified signature.
luke-hill Luke Hill

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that everything is green, but since you touched Percy and that is failing I'm a bit scared to merge it :)

Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona mansona force-pushed the fix-ci branch 6 times, most recently from 93da49c to f5c2ed2 Compare March 6, 2023 10:57
@MelSumner MelSumner dismissed MinThaMie’s stale review March 6, 2023 14:59

All checks are green now

mansona added 2 commits March 6, 2023 17:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Some tests with 'continue-on-error: true' have failed:

  • ember-release-no-deprecations

Created by continue-on-error-comment

@MinThaMie MinThaMie merged commit 49e387b into master Mar 6, 2023
@MinThaMie MinThaMie deleted the fix-ci branch March 6, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants