Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile regression: menu icon no longer sticky #1835

Closed
zachallaun opened this issue Dec 23, 2023 · 6 comments
Closed

Mobile regression: menu icon no longer sticky #1835

zachallaun opened this issue Dec 23, 2023 · 6 comments

Comments

@zachallaun
Copy link
Contributor

On my phone so can't figure out where this was introduced, but I noticed that the menu icon no longer scrolls with the page. This is the case whether the menu is open or not (if you open the menu and scroll the page behind it, the icon scrolls out of view).

This is a pretty big UX regression on mobile, since you have to scroll all the way to the top to navigate elsewhere.

(iOS 17.1.2)

@josevalim
Copy link
Member

Good find. This is good to fix in terms of functionality, you just need to remove this rule at the bottom of layout.css:

  body.sidebar-closed .sidebar-button {
    position: absolute;
  }

But we should probably add gradient + padding back to the top as well, so the button is not immediately overlapping the text. Or alternatively we always keep the hamburger+search visible.

@zachallaun
Copy link
Contributor Author

Or alternatively we always keep the hamburger+search visible.

I think this would be nice! There's a common UI pattern where a navbar hides when you scroll down and then appears when you scroll up slightly -- I think that would work nicely for this case (IIRC Livebook uses this?).

@josevalim
Copy link
Member

Oh, I love this idea! PRs to add this will be very welcome. Then we show the whole search and everything!

@josevalim
Copy link
Member

@zachallaun btw, if you don't plan to tackle this, it is not problem. I can ask Paulo Valim to do it once he is back from holidays.

@zachallaun
Copy link
Contributor Author

@josevalim I don't know that I'll be able to tackle before Paulo would -- if he's able to when he's back, that would be great!

@josevalim
Copy link
Member

This has been fixed in #1838. We shall have a new release sooner than later. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants