Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolink support for handling remote types in records #1763

Merged
merged 9 commits into from Sep 25, 2023
Merged

Autolink support for handling remote types in records #1763

merged 9 commits into from Sep 25, 2023

Conversation

starbelly
Copy link
Contributor

@starbelly starbelly commented Sep 9, 2023 •
edited

This PR is in reference to and resolves starbelly/rebar3_ex_doc#66

@starbelly
Copy link
Contributor Author

Opened as draft, I need to flesh out the commit message.

@paulo-ferraz-oliveira
Copy link
Contributor

I've tried this solution out and it fixes the linked issue 👍

wojtekmach
wojtekmach reviewed Sep 19, 2023
View reviewed changes
test/ex_doc/formatter/html/erlang_test.exs Outdated Show resolved Hide resolved
test/ex_doc/formatter/html/erlang_test.exs Outdated Show resolved Hide resolved
lib/ex_doc/language/erlang.ex Outdated Show resolved Hide resolved
@starbelly @wojtekmach
Update test/ex_doc/formatter/html/erlang_test.exs
7ebaa32 
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
@starbelly
Copy link
Contributor Author

starbelly commented Sep 24, 2023 •
edited

@wojtekmach You wanted to test manually, something went wrong which I tried to make the tests prettier :) If you cherry pick 98d9b69 that should do the trick. I'll look at revisiting this again today, as the solution still seems funky.

Edit

OTP 26 and elixir 1.15 btw, though I would think OTP 25 and OTP 24 would apply as well.

starbelly and others added 2 commits September 24, 2023 13:21
@starbelly @wojtekmach
Update test/ex_doc/formatter/html/erlang_test.exs
b42cd2a 
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
@starbelly
Simple solution and address feedback
a010fb6
@starbelly starbelly marked this pull request as ready for review September 24, 2023 18:36
@starbelly
Copy link
Contributor Author

@wojtekmach This is ready for review with a more "proper" clause in the erlang language module to cover this. As far as making source code for test shorter, we need at least two keys in the record to trigger to trigger this FWIW.

This was referenced Sep 24, 2023
Closed
Closed
@wojtekmach wojtekmach merged commit 16a8f53 into elixir-lang:main Sep 25, 2023
4 checks passed
@wojtekmach
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmach wojtekmach wojtekmach left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal inconsistency with uri_string:uri_string()
3 participants
@starbelly @paulo-ferraz-oliveira @wojtekmach