Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate :since metadata from modules #1680

Merged
merged 3 commits into from Mar 14, 2023
Merged

Propagate :since metadata from modules #1680

merged 3 commits into from Mar 14, 2023

Conversation

whatyouhide
Copy link
Member

@whatyouhide whatyouhide commented Mar 13, 2023

:since was showing for functions, types, and callbacks, but not for modules.

:since was showing for functions, types, and callbacks, but not for
modules.
@josevalim
Copy link
Member

Can you please provide screenshots of how it looks like? IIRC we didn't have a placement for it.

@whatyouhide
Copy link
Member Author

Will do in a few hours when at a computer, but yes it turns our we do 😬, and it looks good too 😁 I tested locally.

@whatyouhide
Copy link
Member Author

@josevalim see screenshot 👇

CleanShot 2023-03-13 at 17 47 51@2x

@josevalim
Copy link
Member

I think the font is not matching the font we have in usual signatures, no?

@whatyouhide
Copy link
Member Author

@josevalim I don't know 😄 Should it be monospaced?

CleanShot 2023-03-13 at 19 55 19@2x

@josevalim
Copy link
Member

I think so, yes!

@whatyouhide
Copy link
Member Author

whatyouhide commented Mar 13, 2023

@josevalim new commit should do it:

CleanShot 2023-03-13 at 20 16 19@2x

@josevalim
Copy link
Member

Can you also please adjust the baseline? The fonts must all start at the same place from the bottom.

Btw, this is what I meant we had no place for it. There is no design for them, so we need to take into account all of the design considerations that happen elsewhere on the page.

@whatyouhide
Copy link
Member Author

@josevalim got it now. If I align the baseline with the module name, it looks pretty bad because it's then not aligned with the </> and gear icons anymore 🤔 An alternative is to put this on a separate line, before the moduledoc starts.

@josevalim
Copy link
Member

You can also love the icons baseline as well. The since and icons should have the same baseline anyway as the title anyway. :)

@whatyouhide whatyouhide changed the title Show :since metadata in modules Propagate :since metadata from modules Mar 14, 2023
@whatyouhide
Copy link
Member Author

@josevalim done, and the implementation is really simple as well. Ready for another review.

@josevalim josevalim merged commit e63e957 into main Mar 14, 2023
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants