feat: add before_closing_*_tag mfa support #1670
Merged
+120
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 3, 2023
yordis
force-pushed
the
add-mfa-before_closing_body_tag
branch
3 times, most recently
from
ce2abe7 to
1b8453f
Compare
yordis
force-pushed
the
add-mfa-before_closing_body_tag
branch
from
1b8453f to
17b4e80
Compare
|
LGTM! We just need to update the docs and we can ship it! |
yordis
changed the title
|
@josevalim Maybe this another PR, but wdyt about supporting maps? The case I'm thinking about is when you just have some static data you want appended, making a callback less valuable.
|
|
Sounds good to me too. |
|
ahhh that is what you meant @starbelly 🤦🏻 I can make another PR. Let me find some time to update some docs. |
yordis
force-pushed
the
add-mfa-before_closing_body_tag
branch
from
17b4e80 to
21d48c3
Compare
|
Ready again |
|
For some reason the build is not working. Can you please rebase just in case? |
yordis
force-pushed
the
add-mfa-before_closing_body_tag
branch
3 times, most recently
from
34b22e9 to
1f2aa07
Compare
yordis
force-pushed
the
add-mfa-before_closing_body_tag
branch
from
1f2aa07 to
9199352
Compare
|
I rebased, but I am unsure what is happening with CI ... |
|
I will merge and play with it. Thanks! |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.