Ensure all modules are properly loaded for "mix gettext.merge" #365
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:nofile
error of #358 has been solved for a while, but I found it's not solved completely.I can still see the
:nofile
error when working with Gettext with custom plural module. I created a repo for reproducing the problem:README.md
contains the following contents:I found the solution is very easy - use
mix loadpaths
, such as:$ mix do loadpaths + gettext.merge priv/gettext --locale en_US
But, to minimize surprises, I believe it would be better to make the changes within
Mix.Tasks.Gettext.Merge
, which helps to reduce the friction for other developers. This PR does it.