Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from ensure_loaded/1 to ensure_compiled/1 #359

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

TeoDiaz
Copy link
Contributor

@TeoDiaz TeoDiaz commented Mar 14, 2023

Fixes #358

We can't use ensure_compiled!/1 for versions under 1.12+

@josevalim
Copy link
Contributor

@TeoDiaz we should rename the function to ensure_compiled! and we should also change it to ensure_compiled! on the if branch.

@josevalim
Copy link
Contributor

I pushed one commit but I left the renaming to you. :)

@coveralls
Copy link

coveralls commented Mar 14, 2023

Pull Request Test Coverage Report for Build 49bf1da0219bcb3ae32d5b2e3ac398d02fc8653d-PR-359

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.738%

Totals Coverage Status
Change from base Build da71fb6d2c9e0a607376b5bb945c80ffc9e18b9b: 0.0%
Covered Lines: 529
Relevant Lines: 583

💛 - Coveralls

@TeoDiaz
Copy link
Contributor Author

TeoDiaz commented Mar 14, 2023

I pushed one commit but I left the renaming to you. :)

Done! Thanks 😉

@whatyouhide
Copy link
Contributor

Thanks @TeoDiaz! 💟

@whatyouhide whatyouhide merged commit d596823 into elixir-gettext:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module is not loaded because :nofile
5 participants