Modal.createDialog(...) throws strict TypeScript errors

[MadLittleMods]

Spawning from matrix-org/matrix-react-sdk#10405 (comment),

Our Modal.createDialog(...) usage throws strict TypeScript errors when you start touching parts of that code.

ex.

Modal.createDialog(ErrorDialog, {
    title: _t("Upload Failed"),
    description: desc,
});

Argument of type 'typeof ErrorDialog' is not assignable to parameter of type 'ComponentType'.

Another example:

Argument of type 'typeof BugReportDialog' is not assignable to parameter of type 'ComponentType'.

Potential solutions

We probably need to fix the Type definitions in Modal.createDialog(...) to more accurately portray what we're doing. I'm not sure what those changes would look like.

[t3chguy]

Targeted by matrix-org/matrix-react-sdk#10387